Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Databricks Asset Bundles schema and fileMatch #4157

Merged

Conversation

shreyas-goenka
Copy link
Contributor

Hi, I'm an engineer at Databricks who owns and maintains the Databricks Asset Bundles schema. Recently, we made a big overhaul of the schema, fixing a bunch of issues (databricks/cli#1700). This PR updates the schema to the latest released version (corresponding to the Databricks CLI version 0.230)

This PR also updates the fileMatch rules to work for databricks.yml and databricks.yaml, and no longer work for .databricks.yml files. This is because .databricks.yml is not an officially supported or recognized extension by Databricks and is not necessarily a pattern we want to encourage.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@shreyas-goenka shreyas-goenka force-pushed the update-databricks-schema branch from 8748d4a to 7aa2608 Compare October 20, 2024 22:20
@hyperupcall
Copy link
Member

Thanks! Once the typo is fixed, I believe the tests should pass, and then I'll be able to merge this$

If you'd like to be mentioned when this file is modified, we have a bot that mentions users as per the CODEOWNERS file - more info is in contribution.md$

@hyperupcall
Copy link
Member

Thanks

@hyperupcall hyperupcall merged commit dcff881 into SchemaStore:master Oct 21, 2024
3 checks passed
benpops89 pushed a commit to benpops89/schemastore that referenced this pull request Nov 21, 2024
)

* Update Databricks Asset Bundles schema and fileMatch

* add id and schema draft version

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix typo

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants